Messages in this thread | | | Date | Wed, 24 Jun 2009 11:07:04 +0200 | From | Oliver Hartkopp <> | Subject | Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM |
| |
Wolfgang Grandegger wrote: > Oliver Hartkopp wrote: >> Wolfgang Grandegger wrote:
>>> We may even consider making CONFIG_CAN >>> depend on HAS_IOMEM like for SPI, USB, Serial, etc. >> Why CONFIG_CAN ?? >> >> CONFIG_CAN provides a network protocol family that can be used e.g. with the >> vcan driver without any hardware. So HAS_IOMEM only has to take care of some >> drivers, that fiddle on CAN controller registers themselves. E.g. for SPI, USB >> and Serial these 'underlying' interfaces bring their own requirements. When we >> depend on SPI, it should bring HAS_IOMEM as a dependency of SPI. > > OK, then s/CONFIG_CAN/CONFIG_CAN_DEV/
IMHO not even CONFIG_CAN_DEV that also provides bittime calculation and standard CAN driver stuff that does not depend on a specific hardware.
HAS_IOMEM should be a dependency on specific drivers (like stated above).
Regards, Oliver
| |