Messages in this thread | | | Date | Tue, 23 Jun 2009 09:19:44 +0200 | From | Ingo Molnar <> | Subject | Re: + printk-add-printk_delay-to-make-messages-readable-for-some-scenarios .patch added to -mm tree |
| |
two minor comments:
> +++ a/kernel/printk.c > @@ -640,6 +640,19 @@ static int recursion_bug; > static int new_text_line = 1; > static char printk_buf[1024]; > > +int printk_delay_msec;
should be __read_mostly.
> + > +static inline void printk_delay(void) > +{ > + if (unlikely(printk_delay_msec)) { > + int m = printk_delay_msec; > + while (m--) {
newline needed after local variable.
Ingo
| |