lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 5/6] ide: fix races in handling of user-space SET XFER commands
From
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Tue, 23 Jun 2009 23:35:51 +0200

I just noticed the following while re-reading this patch.

> @@ -322,10 +322,17 @@ static void ide_error_cmd(ide_drive_t *d
> void ide_finish_cmd(ide_drive_t *drive, struct ide_cmd *cmd, u8 stat)
> {
> struct request *rq = drive->hwif->rq;
> - u8 err = ide_read_error(drive);
> + u8 err = ide_read_error(drive), nsect = cmd->tf.nsect;
> + u8 set_xfer = !!(cmd->tf_flags & IDE_TFLAG_SET_XFER);
>

There is no reason to use 'u8' for set_xfer. It's a boolean
so use 'bool' and then you can eliminate that "!!()" double
negate.

The only reason you would need that double-negate is because
cmd->tf_flags is a u16 and IDE_TFLAG_SET_XFER is in fact one
of those upper 8-bits.

Further confirming that a bool would be a better choice here.


\
 
 \ /
  Last update: 2009-06-24 01:43    [W:0.042 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site