Messages in this thread | | | Date | Tue, 23 Jun 2009 13:13:33 +0900 | From | Daisuke Nishimura <> | Subject | Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir |
| |
On Tue, 23 Jun 2009 09:22:23 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Mon, 22 Jun 2009 18:37:07 +0900 > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > previous discussion was this => http://marc.info/?t=124478543600001&r=1&w=2 > > > > I think this is a minimum fix (in code size and behavior) and because > > we can take a BIG LOCK, this kind of check is necessary, anyway. > > Any comments are welcome. > > I'll split this into 2 patches...and I found I should check page-migration, too. I'll wait a new version, but can you explain in advance this page-migration case ?
> > +static int mem_cgroup_retry_rmdir(struct cgroup_subsys *ss, > > + struct cgroup *cont) > > +{ > > + struct mem_cgroup *mem = mem_cgroup_from_cont(cont); > > + > > + if (res_counter_read_u64(&memcg->res, RES_USAGE)) It should be &mem->res.
> > + return 1; > > + return 0; > > +} > > + > > +
Thanks, Daisuke Nishimura.
> Then, modifing swap account logic is not help, at last. > > Thanks, > -Kame >
| |