lkml.org 
[lkml]   [2009]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] atmel-mci: Unified Atmel MCI drivers (AVR32 & AT91)
Haavard Skinnemoen :
> Nicolas Ferre wrote:
>>> -#define ATMCI_DATA_ERROR_FLAGS (MCI_DCRCE | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>>> +#define ATMCI_DATA_ERROR_FLAGS (MCI_RINDE | MCI_RDIRE | MCI_RCRCE \
>>> + | MCI_RENDE | MCI_RTOE | MCI_DCRCE \
>>> + | MCI_DTOE | MCI_OVRE | MCI_UNRE)
>> Haavard, is it ok to add those flags on an AVR32 platform for now ?
>
> It probably doesn't hurt on AVR32. But I'm not a great fan since it
> seems like the wrong thing to do, and it may simply mask the real
> problem.

Agreed.

To move forward, I will submit a first patch series without those flags
added.

Best regards,
--
Nicolas Ferre



\
 
 \ /
  Last update: 2009-06-23 18:31    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site