Messages in this thread | | | Subject | Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB | From | James Bottomley <> | Date | Mon, 22 Jun 2009 23:00:53 -0500 |
| |
On Mon, 2009-06-22 at 19:29 -0700, Linus Torvalds wrote: > > On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote: > > > + /* > > + * This initializes the mutex used by get/put_online_cpus() > > + * which is used by SLAB > > + */ > > + cpu_hotplug_init(); > > Oh fudge it. > > Why not get rid of that stupid thing, rather than have that subtle > dependency and a comment for it. > > IOW, does this simpler alternative also work?
Yes, works for me.
James
| |