lkml.org 
[lkml]   [2009]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH] cgroup: fix permanent wait in rmdir
From
Ingo Molnar wrote:
>> Ah, while I test 2.6.30-git18 (includes above patch), I don't see
>> above stack dump (with LIST_DEBUG=y) under quick memory pressure
>> test...
>
> Note, it still occurs even with latest -git (f234012).
>
Could you try this ? (Sorry, I can't send a patch right now)
== vmscan.c
865 static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
866 struct list_head *src, struct list_head *dst,
867 unsigned long *scanned, int order, int mode, int file)
868 {
869 unsigned long nr_taken = 0;
870 unsigned long scan;
871
<snip>
930 /* Check that we have not crossed a zone
boundary. */
931 if (unlikely(page_zone_id(cursor_page) !=
zone_id))
932 continue;
933 if (__isolate_lru_page(cursor_page, mode,
file) == 0) {
934 list_move(&cursor_page->lru, dst);
935 mem_cgroup_del_lru(page);
936 nr_taken++;
937 scan++;
938 }

change line 935
from
mem_cgroup_del_lru(page);
to
mem_cgroup_del_lru(cursor_page);


Thanks,
-Kame






\
 
 \ /
  Last update: 2009-06-22 14:35    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site