lkml.org 
[lkml]   [2009]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] x86: mm/hugetlbpage.c fix style problems
From
Date
On Sun, 2009-06-21 at 13:22 +0200, Ingo Molnar wrote:

> this change is not an improvement either.
>
> Plus at a first glance that file has a couple of other problems as
> well beyond trivial style issue:
>
> - dead code which should be removed
>
> - a 64-bit only boot option that should probably be extended to
> 32-bit as well
>
> - insanely long function names with local scope, causing ugly
> linebreaks
>
> and more style issues as well:
>
> - various inconsistent capitalizations in comment blocks
>
> - some other small details as well
>
> Lets try to do a genuinely big and comprehensive forward step that
> addresses all these issues (and any other issues that are in that
> file), ok?
>

ok, I will try.

--
JSR



\
 
 \ /
  Last update: 2009-06-21 13:43    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site