[lkml]   [2009]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] mm: pass mm to grab_swap_token
    On Sun, 21 Jun 2009 14:02:43 +0100 (BST)
    Hugh Dickins <> wrote:

    > If a kthread happens to use get_user_pages() on an mm (as KSM does),
    > there's a chance that it will end up trying to read in a swap page,
    > then oops in grab_swap_token() because the kthread has no mm: GUP
    > passes down the right mm, so grab_swap_token() ought to be using it.
    > We have not identified a stronger case than KSM's daemon (not yet
    > in mainline), but the issue must have come up before, since RHEL has
    > included a fix for this for years (though a different fix, they just
    > back out of grab_swap_token if current->mm is unset: which is what
    > we first proposed, but using the right mm here seems more correct).
    > Reported-by: Izik Eidus <>
    > Signed-off-by: Johannes Weiner <>
    > Signed-off-by: Hugh Dickins <>
    > Acked-by: Rik van Riel <>
    Reviewed-by: Minchan Kim <>

    I already added my sign to Hannes but it is folded in this patch.

    Kinds Regards
    Minchan Kim

     \ /
      Last update: 2009-06-22 02:43    [W:0.021 / U:15.832 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site