lkml.org 
[lkml]   [2009]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC patch] reset TSC at the begining of check_tsc_warp
From
Date
Luming Yu <luming.yu@gmail.com> writes:

> Hello,
>
> Without this patch, we always get kernel warning that TSC warp between CPUs,
> and TSC is marked unstable due to check_tsc_sync_source failed if the CPUs
> have the problem of not-synced initial TSC.
>
> It hurts CPUs with constant-tsc feature, but with unsynced initial TSC value...
>
> The downside is we could break perfect synced TSC with this patch.

s/could/will definitely/

So you're hurting the good systems for one buggy box. I don't think
that's a good idea.

Possible alternatives:
- black list that system with DMI
- try to detect it by checking constant_tsc and still unsynchronized TSC
- just give up and say the system won't be able to use TSC unless the BIOS
fixes its act.

The third option is probably not the worst.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-06-02 09:59    [W:0.048 / U:1.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site