Messages in this thread | | | Subject | Re: [PATCH 3/7] percpu: clean up percpu variable definitions | From | Benjamin Herrenschmidt <> | Date | Tue, 02 Jun 2009 15:08:56 +1000 |
| |
On Mon, 2009-06-01 at 20:36 +0900, Tejun Heo wrote: > > Whether the volatile is actually needed or not, it's bad to have this > > kind of potential behavior changing nugget hidden in this seemingly > > inocuous change. Especially if you're the poor soul who ends up > > having to debug it :-/ > > You're right. Aieee... how do I feed volatile to the DEFINE macro. > I'll think of something.
Or better, work with the cris maintainer to figure out whether it's needed (it probably isn't) and have a pre-requisite patch that removes it before your series :-)
Cheers, Ben.
| |