Messages in this thread | | | Date | Tue, 2 Jun 2009 17:09:52 +0200 | From | Nick Piggin <> | Subject | Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3 |
| |
On Tue, Jun 02, 2009 at 02:47:57PM +0200, Andi Kleen wrote: > On Tue, Jun 02, 2009 at 02:00:42PM +0200, Nick Piggin wrote:
[snip: reusing truncate.c code]
> > With all that writing you could have just done it. It's really > > I would have done it if it made sense to me, but so far it hasn't. > > The problem with your suggestion is that you do the big picture, > but seem to skip over a lot of details. But details matter.
BTW. just to answer this point. The reason maybe for this is because the default response to my concerns seems to have been "you're wrong". Not "i don't understand, can you detail", and not "i don't agree because ...".
I may well be wrong (in this case I'm quite sure I'm not), but if you say I'm wrong, then I assume that you understand what I'm talking about and have a fair idea of the details.
Anyway don't worry. I get that a lot. I do really want to help get this merged.
| |