lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] New ASoC Drivers for ADI AD1938 codec
From
Date
On Fri, 2009-06-19 at 10:35 +0100, Liam Girdwood wrote:
> On Fri, 2009-06-19 at 17:28 +0800, Barry Song wrote:
> > 1. add AD1938 codec driver (codec)
> > 2. add blackfin SPORT-TDM DAI and PCM driver (platform)
> > 3. add bf5xx board with AD1938 driver (machine)
> > Signed-off-by: Barry Song <21cnbao@gmail.com>
> > ---
> > include/sound/soc-dai.h | 1 +
> > sound/soc/blackfin/Kconfig | 46 +++-
> > sound/soc/blackfin/Makefile | 6 +
> > sound/soc/blackfin/bf5xx-ad1938.c | 178 ++++++++++++
> > sound/soc/blackfin/bf5xx-tdm-pcm.c | 330 ++++++++++++++++++++++
> > sound/soc/blackfin/bf5xx-tdm-pcm.h | 21 ++
> > sound/soc/blackfin/bf5xx-tdm.c | 295 +++++++++++++++++++
> > sound/soc/blackfin/bf5xx-tdm.h | 14 +
> > sound/soc/codecs/Kconfig | 4 +
> > sound/soc/codecs/Makefile | 2 +
> > sound/soc/codecs/ad1938.c | 548 ++++++++++++++++++++++++++++++++++++
> > sound/soc/codecs/ad1938.h | 68 +++++
> > 12 files changed, 1512 insertions(+), 1 deletions(-)
> > create mode 100644 sound/soc/blackfin/bf5xx-ad1938.c
> > create mode 100644 sound/soc/blackfin/bf5xx-tdm-pcm.c
> > create mode 100644 sound/soc/blackfin/bf5xx-tdm-pcm.h
> > create mode 100644 sound/soc/blackfin/bf5xx-tdm.c
> > create mode 100644 sound/soc/blackfin/bf5xx-tdm.h
> > create mode 100644 sound/soc/codecs/ad1938.c
> > create mode 100644 sound/soc/codecs/ad1938.h
> >
>
> Could you break this patch into smaller chunks. This should make it
> easier to review and apply.

and also add a description for each patch in your series.

Thanks

Liam



\
 
 \ /
  Last update: 2009-06-19 11:43    [W:2.754 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site