[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 01/17] arm: arch_ptrace clean-up
    On Fri, Apr 24, 2009 at 05:07:32PM -0700, Roland McGrath wrote:
    > This cleans up arch_ptrace() on arm to use the generic ptrace_request()
    > for everything it can. This gets rid of the non-arch ptrace internals
    > magic from the arch code.

    It also changes the semantics a bit, and I don't buy the "it doesn't
    matter" comments, especially in the PT_SINGLESTEP case. Having
    PT_SINGLESTEP set the flag but later fail is not nice behaviour at all,
    it means that, despite the ptrace call failing, the next time that the
    task encounters a signal, it will enter single stepping mode.

    Therefore, I believe this patch is wrong.

    Russell King
    Linux kernel 2.6 ARM Linux -
    maintainer of:

     \ /
      Last update: 2009-06-19 11:17    [W:0.018 / U:1.480 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site