lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kmemleak: use pr_fmt
From
Date
On Fri, 2009-06-19 at 10:53 +0100, Catalin Marinas wrote:
> Thanks for the patch. It missed one pr_info case (actually invoked via
> the pr_helper macro).

This change will affect the seq_printf uses.
Some think the seq output should be immutable.
Perhaps that's important to you or others.

An option is to change the print_helper
pr_info to a printk(KERN_INFO and not change
any uses of print_helper

#define print_helper(seq, x...) do { \
struct seq_file *s = (seq); \
if (s) \
seq_printf(s, x); \
else \
printk(KERN_INFO x); \
} while (0)

> > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > +
> ^ - empty space at the end of the line (git told me about it)

Thanks for letting me know. I'll fix my tools.

Joe




\
 
 \ /
  Last update: 2009-06-20 03:27    [W:0.259 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site