lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] HWMON: max6650, fix lock imbalance
On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote:
> Add omitted update_lock to one switch/case in set_div.

Ahem, yes, thanks!

>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

Signed-off-by: Hans J. Koch <hjk@linutronix.de>

> ---
> drivers/hwmon/max6650.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> index 86142a8..58f66be 100644
> --- a/drivers/hwmon/max6650.c
> +++ b/drivers/hwmon/max6650.c
> @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
> data->count = 3;
> break;
> default:
> + mutex_unlock(&data->update_lock);
> dev_err(&client->dev,
> "illegal value for fan divider (%d)\n", div);
> return -EINVAL;
> --
> 1.6.3.2


\
 
 \ /
  Last update: 2009-06-20 01:09    [W:0.598 / U:0.060 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site