lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/5] trace_stat: don't increment @pos in stat_seq_start()
    It's wrong to increment @pos in stat_seq_start(). It causes some
    stat entries lost when reading stat file, if the output of the file
    is large than PAGE_SIZE.

    [ Impact: fix missing entries when reading a stat file ]

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/trace/trace_stat.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c
    index c006437..e66f5e4 100644
    --- a/kernel/trace/trace_stat.c
    +++ b/kernel/trace/trace_stat.c
    @@ -199,17 +199,13 @@ static void *stat_seq_start(struct seq_file *s, loff_t *pos)
    mutex_lock(&session->stat_mutex);

    /* If we are in the beginning of the file, print the headers */
    - if (!*pos && session->ts->stat_headers) {
    - (*pos)++;
    + if (!*pos && session->ts->stat_headers)
    return SEQ_START_TOKEN;
    - }

    node = rb_first(&session->stat_root);
    for (i = 0; node && i < *pos; i++)
    node = rb_next(node);

    - (*pos)++;
    -
    return node;
    }

    --
    1.5.4.rc3





    \
     
     \ /
      Last update: 2009-06-19 08:47    [W:0.020 / U:30.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site