lkml.org 
[lkml]   [2009]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netfilter: conntrack: death_by_timeout() fix
Eric Dumazet wrote:
> [PATCH] netfilter: conntrack: death_by_timeout() fix
>
> death_by_timeout() might delete a conntrack from hash list
> and insert it in dying list.
>
> nf_ct_delete_from_lists(ct);
> nf_ct_insert_dying_list(ct);
>
> I believe a (lockless) reader could *catch* ct while doing a lookup
> and miss the end of its chain.
> (nulls lookup algo must check the null value at the end of lookup and
> should restart if the null value is not the expected one.
> cf Documentation/RCU/rculist_nulls.txt for details)
>
> We need to change nf_conntrack_init_net() and use a different "null" value,
> guaranteed not being used in regular lists. Choose very large values, since
> hash table uses [0..size-1] null values.

Applied, thanks Eric.


\
 
 \ /
  Last update: 2009-06-19 13:17    [W:0.067 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site