lkml.org 
[lkml]   [2009]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/6] exofs: Fix bio leak in error handling path (sync read)
    Date
    When failing a read request in the sync path, called from
    write_begin, I forgot to free the allocated bio, fix it.

    Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
    ---
    fs/exofs/inode.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
    index 77d0a29..bb5d6ed 100644
    --- a/fs/exofs/inode.c
    +++ b/fs/exofs/inode.c
    @@ -295,6 +295,9 @@ static int read_exec(struct page_collect *pcol, bool is_sync)
    err:
    if (!is_sync)
    _unlock_pcol_pages(pcol, ret, READ);
    + else /* Pages unlocked by caller in sync mode only free bio */
    + pcol_free(pcol);
    +
    kfree(pcol_copy);
    if (or)
    osd_end_request(or);
    --
    1.6.2.1


    \
     
     \ /
      Last update: 2009-06-17 18:07    [W:0.023 / U:3.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site