Messages in this thread | | | Date | Tue, 16 Jun 2009 23:31:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] Char: tty, fix tty_port_block_til_ready waiting |
| |
On Tue, 16 Jun 2009 21:13:00 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
> Use DEFINE_WAIT instead of DECLARE_WAITQUEUE, because we use > prepare/finish_wait since commit > 3e3b5c087799e536871c8261b05bc28e4783c8da > (tty: use prepare/finish_wait) > > Otherwise we would oops in finish_wait. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > --- > drivers/char/tty_port.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/char/tty_port.c b/drivers/char/tty_port.c > index 62dadfc..a8ed648 100644 > --- a/drivers/char/tty_port.c > +++ b/drivers/char/tty_port.c > @@ -193,7 +193,7 @@ int tty_port_block_til_ready(struct tty_port *port, > { > int do_clocal = 0, retval; > unsigned long flags; > - DECLARE_WAITQUEUE(wait, current); > + DEFINE_WAIT(wait, current);
That won't compile. DEFINE_WAIT(wait) will though.
| |