Messages in this thread | | | Date | Tue, 16 Jun 2009 22:44:02 +0200 | From | Johannes Stezenbach <> | Subject | Re: 2.6.30: hibernation/swsusp lockup due to acpi-cpufreq |
| |
On Tue, Jun 16, 2009 at 01:25:58PM -0700, Pallipadi, Venkatesh wrote: > > diff --git a/kernel/up.c b/kernel/up.c > index 1ff27a2..a4318ff 100644 > --- a/kernel/up.c > +++ b/kernel/up.c > @@ -10,11 +10,15 @@ > int smp_call_function_single(int cpu, void (*func) (void *info), void *info, > int wait) > { > + unsigned long flags; > + > WARN_ON(cpu != 0); > > - local_irq_disable(); > + WARN_ON(irqs_disabled()); > + > + local_irq_save(flags); > (func)(info); > - local_irq_enable(); > + local_irq_restore(flags); > > return 0; > } >
PS: It seems like a good idea to apply this patch with the warning even if the root cause of the hibernate problem is elsewhere, for better debuggability of such issues?
Johannes
| |