lkml.org 
[lkml]   [2009]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] LIB: remove unmatched write_lock() in gen_pool_destroy
On Tue, 16 Jun 2009 10:23:08 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:

> On Mon, 15 Jun 2009, Andrew Morton wrote:
>
> > > > this doesn't really qualify for trivial tree, as it introduces a
> > > > significant code change. Adding some CCs.
> > > Looks ok to me. Its dumb to aquire the lock you're gonna free anyway.
> > > Maybe some BUG_ON() that sez nobody better be holding this lock?
> > CONFIG_DEBUG_OBJECTS_FREE could detect the freeing of a held rwlock.
> > But probably it hasn't been wired up to handle rwlocks.
>
> Hmm, in fact ... am I just completely blind, or is the only user of
> CONFIG_DEBUG_OBJECTS_FREE the timer code?

Could be. That infrastructure hasn't really been followed up on yet.

There's also CONFIG_DEBUG_LOCK_ALLOC which perhaps could/should be
implemented via debugobjects.



\
 
 \ /
  Last update: 2009-06-16 10:37    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site