lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] asm-generic: add EMAXERRNO
From
Date
linux-arch-owner@vger.kernel.org 写于 2009-06-15 22:02:42:

> On Monday 15 June 2009, Matthew Wilcox wrote:
> > On Mon, Jun 15, 2009 at 03:30:09PM +0200, Arnd Bergmann wrote:
> > > Some architectures want to flag error returns from a syscall based
on
> > > the return value. The range from zero to -511 is for errors that
> > > we can return to user space, so add a #define for this to
> > > include/asm-generic/errno.h.
> >
> > I thought we could return anything up to -4095.
>
> Sort of, yes. Internally to the kernel, we use anything up to 4095,
> that's e.g. IS_ERR_VALUE checks for.
>
> Error numbers from 512 to 4095 are internal and should never be seen
> by the user.
>
> In reality, it probably does not matter at all because we know what
> error numbers we use. Now that you pointed me to include/linux/err.h,
> that already defines MAX_ERRNO.
>
> Liqin, I think I'd prefer to just drop my patch again, and you can
> use MAX_ERRNO, which is defined in err.h.
>
OK.
But I think move MAX_ERRNO define from include/linux/err.h to
include/asm-generic/errno.h will be more clear. And no harm to
include/linux/err.h file.

liqin
--
\
 
 \ /
  Last update: 2009-06-16 05:33    [W:2.156 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site