Messages in this thread |  | | | Date | Mon, 15 Jun 2009 17:35:57 -0700 | | From | Greg KH <> | | Subject | Re: [PATCH 21/22] HWPOISON: send uevent to report memory corruption |
| |
On Mon, Jun 15, 2009 at 10:45:41AM +0800, Wu Fengguang wrote: > +static void hwpoison_release(struct kobject *kobj) > +{ > +} > + > +static struct kobj_type hwpoison_ktype = { > + .release = hwpoison_release, > +};
{sigh} Why did you include an empty release function? Was it because the kernel complained when you had no release function? So, why would you think that the acceptable solution to that warning would be an empty release function instead?
Hint, this is totally wrong, provide a release function that ACTUALLY DOES SOMETHING!!! Read the kobject documentation for details as to what you need to do here.
ugh, I'm so tired of repeating this year after year after year, I feel like a broken record...
This is broken, please fix it.
greg k-h
|  |