lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 3/3] Count the number of times zone_reclaim() scans and fails
    On Thu, 11 Jun 2009 11:47:53 +0100
    Mel Gorman <mel@csn.ul.ie> wrote:

    > + PGSCAN_ZONERECLAIM_FAILED,
    > @@ -2492,6 +2492,9 @@ int zone_reclaim(struct zone *zone, gfp_t gfp_mask, unsigned int order)
    > + "zreclaim_failed",

    So we have "zonereclaim", "zone_reclaim" and "zreclaim", which isn't
    terribly developer-friendly.


    This?

    --- a/include/linux/vmstat.h~vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails-fix
    +++ a/include/linux/vmstat.h
    @@ -37,7 +37,7 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS
    FOR_ALL_ZONES(PGSCAN_KSWAPD),
    FOR_ALL_ZONES(PGSCAN_DIRECT),
    #ifdef CONFIG_NUMA
    - PGSCAN_ZONERECLAIM_FAILED,
    + PGSCAN_ZONE_RECLAIM_FAILED,
    #endif
    PGINODESTEAL, SLABS_SCANNED, KSWAPD_STEAL, KSWAPD_INODESTEAL,
    PAGEOUTRUN, ALLOCSTALL, PGROTATED,
    diff -puN mm/vmscan.c~vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails-fix mm/vmscan.c
    --- a/mm/vmscan.c~vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails-fix
    +++ a/mm/vmscan.c
    @@ -2520,7 +2520,7 @@ int zone_reclaim(struct zone *zone, gfp_
    zone_clear_flag(zone, ZONE_RECLAIM_LOCKED);

    if (!ret)
    - count_vm_event(PGSCAN_ZONERECLAIM_FAILED);
    + count_vm_event(PGSCAN_ZONE_RECLAIM_FAILED);

    return ret;
    }
    diff -puN mm/vmstat.c~vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails-fix mm/vmstat.c
    --- a/mm/vmstat.c~vmscan-count-the-number-of-times-zone_reclaim-scans-and-fails-fix
    +++ a/mm/vmstat.c
    @@ -674,7 +674,7 @@ static const char * const vmstat_text[]
    TEXTS_FOR_ZONES("pgscan_direct")

    #ifdef CONFIG_NUMA
    - "zreclaim_failed",
    + "zone_reclaim_failed",
    #endif
    "pginodesteal",
    "slabs_scanned",
    _


    \
     
     \ /
      Last update: 2009-06-15 23:23    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean