Messages in this thread | | | Date | Mon, 15 Jun 2009 11:25:26 -0700 | Subject | Re: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device | From | Brian Swetland <> |
| |
On Mon, Jun 15, 2009 at 6:22 AM, Pavel Machek<pavel@ucw.cz> wrote: >> >> +config MACH_TROUT >> + default y >> + bool "HTC Dream (aka trout)" >> + help >> + Support for the HTC Dream, T-Mobile G1, Android ADP1 devices. >> + >> endif > > ...but I guess renaming config option makes sense too..
This is trickier, as MACH_* is autogenerated based on the machine name, which also becomes the machine name userspace sees.
>> +static void __init trout_init_irq(void) >> +{ >> + msm_init_irq(); >> +} > > ...and most occurences of trout, here, too... (I'm not sure if some > are required for compatibility with existing userland?)
Yup -- userland depends on the name. We could rename the functions in the board file though as that wouldn't break anything.
Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |