lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] cpumask: avoid playing with cpus_allowed in powernow-k8.c
Date
From
> cpumask: avoid playing with cpus_allowed in powernow-k8.c
>
> It's generally a very bad idea to mug some process's cpumask: it could
> legitimately and reasonably be changed by root, which could break us
> (if done before our code) or them (if we restore the wrong value).
>
> I did not replace powernowk8_target; it needs fixing, but it grabs a
> mutex (so no smp_call_function_single here) but Mark points out it can
> be called multiple times per second, so work_on_cpu is too heavy.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> To: davej@redhat.com
> To: cpufreq@vger.kernel.org
> Cc: mark.langsdorf@amd.com

I ran this over the weekend on a 24 core box without
any issues. Please commit.

Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
Tested-by: Mark Langsdorf <mark.langsdorf@amd.com>



\
 
 \ /
  Last update: 2009-06-15 17:43    [from the cache]
©2003-2011 Jasper Spaans