lkml.org 
[lkml]   [2009]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] [ARM] msm: add minimal board file for HTC Dream device
    Hi!

    > Signed-off-by: Brian Swetland <swetland@google.com>
    > ---
    > arch/arm/mach-msm/Kconfig | 6 ++
    > arch/arm/mach-msm/Makefile | 1 +
    > arch/arm/mach-msm/board-dream.c | 113 +++++++++++++++++++++++++++++++++++++++
    > arch/arm/mach-msm/board-dream.h | 5 ++
    > 4 files changed, 125 insertions(+), 0 deletions(-)
    > create mode 100644 arch/arm/mach-msm/board-dream.c
    > create mode 100644 arch/arm/mach-msm/board-dream.h

    Thanks for renaming the board-* files...

    > diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
    > index 35f2a90..f780086 100644
    > --- a/arch/arm/mach-msm/Kconfig
    > +++ b/arch/arm/mach-msm/Kconfig
    > @@ -34,4 +34,10 @@ config MACH_HALIBUT
    > help
    > Support for the Qualcomm SURF7201A eval board.
    >
    > +config MACH_TROUT
    > + default y
    > + bool "HTC Dream (aka trout)"
    > + help
    > + Support for the HTC Dream, T-Mobile G1, Android ADP1 devices.
    > +
    > endif

    ...but I guess renaming config option makes sense too..

    > +static void __init trout_init_irq(void)
    > +{
    > + msm_init_irq();
    > +}

    ...and most occurences of trout, here, too... (I'm not sure if some
    are required for compatibility with existing userland?)
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-06-15 15:25    [W:0.040 / U:30.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site