lkml.org 
[lkml]   [2009]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] asm-generic: drop HARDIRQ_BITS definition from hardirq.h
    Date
    linux/hardirq.h contains a fallback for HARDIRQ_BITS to 10
    if it's not defined, so it is pointless to define a default
    of 8 in asm/hardirq.h. There does not seem to be a good
    reason why an architecture would want to limit the number
    of hardirqs this way.

    Reported-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    include/asm-generic/hardirq.h | 13 -------------
    1 files changed, 0 insertions(+), 13 deletions(-)
    On Sunday 14 June 2009, Mike Frysinger wrote:

    Mike Frysinger wrote:
    > is there any downsides to using a "too large" value ? i.e. if my
    > system has less than 256, does it make any difference at all if it's
    > set to 10 ?
    > -mike

    None that I know of. I'm queuing this patch in my asm-generic tree now,
    unless Steven or someone else has a better idea.

    Arnd <><

    diff --git a/include/asm-generic/hardirq.h b/include/asm-generic/hardirq.h
    index 3d5d2c9..23bb4da 100644
    --- a/include/asm-generic/hardirq.h
    +++ b/include/asm-generic/hardirq.h
    @@ -11,19 +11,6 @@ typedef struct {

    #include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */

    -#ifndef HARDIRQ_BITS
    -#define HARDIRQ_BITS 8
    -#endif
    -
    -/*
    - * The hardirq mask has to be large enough to have
    - * space for potentially all IRQ sources in the system
    - * nesting on a single CPU:
    - */
    -#if (1 << HARDIRQ_BITS) < NR_IRQS
    -# error HARDIRQ_BITS is too low!
    -#endif
    -
    #ifndef ack_bad_irq
    static inline void ack_bad_irq(unsigned int irq)
    {
    --
    1.6.3.1


    \
     
     \ /
      Last update: 2009-06-14 22:47    [W:0.047 / U:89.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site