lkml.org 
[lkml]   [2009]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 06/14] Pramfs: Include files
    Date
    On Saturday 13 June 2009, Sam Ravnborg wrote:
    > > + union {
    > > + struct {
    > > + /*
    > > + * ptr to row block of 2D block pointer array,
    > > + * file block #'s 0 to (blocksize/4)^2 - 1.
    > > + */
    > > + off_t row_block;
    >
    > It is my understanding that we shall use: __kernel_off_t
    > in exported headers.

    That is a correct understanding in general, however this case is
    different, because it describes an on-disk data structure,
    not a kernel to user space interface. Here, __kernel_off_t is just
    as wrong as off_t, because it will differ between 32 and 64 bit
    architectures, making the fs layout incompatible. I'd suggest
    simply defining this as __u64.

    Moreover, file system layout should be described in terms of
    big-endian or little-endian types (e.g. __be64 or __le64),
    together with the right accessor functions.

    Arnd <><


    \
     
     \ /
      Last update: 2009-06-14 01:03    [W:0.031 / U:2.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site