Messages in this thread | | | From | Mike Frysinger <> | Date | Sat, 13 Jun 2009 11:59:50 -0400 | Subject | Re: [PATCH] asm-generic: uaccess: fix up local access_ok() usage |
| |
On Sat, Jun 13, 2009 at 10:30, Mike Frysinger wrote: > There's no reason that I can see to use the short __access_ok() form > directly when the access_ok() is clearer in intent and for more people, > expands to the same C code (i.e. always specify the first field -- access > type). Not all no-mmu systems lack memory protection, so the read/write > could feasibly be checked.
hmm, and it also fixes the crazy amount of warnings you get otherwise because the access_ok() expansion includes an unsigned long cast: CC [M] fs/smbfs/request.o In file included from /usr/local/src/linux/linux-2.6/arch/blackfin/include/asm/uaccess.h:17, from include/net/checksum.h:26, from include/linux/skbuff.h:28, from include/linux/ip.h:109, from include/net/ip.h:27, from fs/smbfs/smbiod.c:23: include/asm-generic/uaccess.h: In function ‘copy_from_user’: include/asm-generic/uaccess.h:247: warning: passing argument 1 of ‘_access_ok’ makes integer from pointer without a cast include/asm-generic/uaccess.h: In function ‘copy_to_user’: include/asm-generic/uaccess.h:257: warning: passing argument 1 of ‘_access_ok’ makes integer from pointer without a cast include/asm-generic/uaccess.h: In function ‘strncpy_from_user’: include/asm-generic/uaccess.h:281: warning: passing argument 1 of ‘_access_ok’ makes integer from pointer without a cast include/asm-generic/uaccess.h: In function ‘clear_user’: include/asm-generic/uaccess.h:319: warning: passing argument 1 of ‘_access_ok’ makes integer from pointer without a cast -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |