Messages in this thread | | | Date | Fri, 12 Jun 2009 08:48:24 +0100 | From | Richard Kennedy <> | Subject | Re: [PATCH 2/2] posix-cpu-timers: remove tasklist_lock where we can |
| |
Stanislaw Gruszka wrote: > tasklist_lock is not needed to protect find_task_by_vpid() nor > thread_group_leader() nor same_thread_group() , use rcu_read_lock() instead. > > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> > --- > kernel/posix-cpu-timers.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c > index bece7c0..1d9cdf3 100644 > --- a/kernel/posix-cpu-timers.c > +++ b/kernel/posix-cpu-timers.c > @@ -37,13 +37,13 @@ static int check_clock(const clockid_t which_clock) > if (pid == 0) > return 0; > > - read_lock(&tasklist_lock); > + rcu_read_lock(); > p = find_task_by_vpid(pid); > if (!p || !(CPUCLOCK_PERTHREAD(which_clock) ? > same_thread_group(p, current) : thread_group_leader(p))) { > error = -EINVAL; > } > - read_unlock(&tasklist_lock); > + rcu_read_lock(); > Did you really intend to replace an unlock with a lock?
regards Richard
| |