Messages in this thread | | | Date | Fri, 12 Jun 2009 09:49:26 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: slab: setup allocators earlier in the boot sequence |
| |
On Fri, 12 Jun 2009, Pekka Enberg wrote:
> So I am sending the GFP_NOWAIT conversion for boot code even though you > didn't seem to like it (but didn't explicitly NAK) as it fixes problems > on x86.
The use GFP_NOWAIT means that the caller sites are still special cased for an early boot situation. After bootstrap is complete the sites may use GFP_KERNEL instead. Bad.
Best thing to do is to recognize the fact that we are still in early boot in the allocators. Derived allocators (such as slab and vmalloc) mask bits using GFP_RECLAIM_MASK and when doing allocations through the page allocator. You could make GFP_RECLAIM_MASK a variable. During boot __GFP_WAIT would not be set in GFP_RECLAIM_MASK.
| |