Messages in this thread | | | From | Mike Frysinger <> | Date | Fri, 12 Jun 2009 06:45:17 -0400 | Subject | Re: [PATCH] tty: fix unused warning when TCGETX is not defined |
| |
On Fri, Jun 12, 2009 at 06:38, Alan Cox wrote: >> > If I wasn't so nice I'd just make it and the lack of BOTHER definitions >> > on platforms error. Really there shouldn't be anyone without the features >> > defined ;) >> >> if i knew a lick about these extended tty pieces, i'd look at hooking them up >> >> are these really arch specific ? > > The ioctl numbers have to be (although most platforms use the same > values), and the "BOTHER" definition for arbitary baud rates depends on > the format of struct termios - which again varies by architecture. Its > usually the case that CBAUDEX|0 isn't used for anything so we use that > for BOTHER.
mmm BOTHER is used to get arbitrary speeds right ? i recall testing that on Blackfin already so i'm pretty sure that works ...
> Other than the numbering they are not arch specific, so just pick the > constants for the platform.
the guys who did the original Blackfin arch port simply copied the x86 termios stuff (which actually kind of sucks because it means they copied the termios2 wart)
wonder if people would get annoyed if i changed the Blackfin headers to do #include <asm/../../../x86/include/asm/foo.h> ;)
doing a diff between x86 and Blackfin headers shows that termbits/termios are exact copies (ignoring the #ifdef header protection) and that the Blackfin ioctls.h is missing: TIOCGRS485 TIOCSRS485 TCGETX TCSETX TCSETXF TCSETXW TIOCGHAYESESP TIOCSHAYESESP -mike
| |