Messages in this thread | | | Date | Fri, 12 Jun 2009 12:18:05 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] lis3: add click function |
| |
On Fri 2009-06-12 12:13:00, Daniel Mack wrote: > On Thu, Jun 11, 2009 at 11:07:55PM +0200, Pavel Machek wrote: > > > The LIS3 accelerometer chip has a 'click' feature which can be used to > > > detect sudden motion on any of the three axis. Configuration data is > > > passed via spi platform_data and no action is taken if that's not > > > specified, so it won't harm any existing platform. > > > > > > To make the configuration effective, the IRQ lines need to be set up > > > appropriately. This patch also adds a way to do that from board support > > > code. > > > > > > The DD_* definitions were removed because I couldn't find any reference > > > of them in the datasheet and the overlapped with the CLICK_ register > > > space. > > > > > > Signed-off-by: Daniel Mack <daniel@caiaq.de> > > > Cc: Pavel Machek <pavel@ucw.cz> > > > Cc: Eric Piel <eric.piel@tremplin-utc.net> > > > > Well, patch looks mostly okay, but it would be nice to separate > > cleanups onto separate patch... > > Yes, I've seen that, but considered the two minor things too small to > deserve a seperate patch. Do you want me resend?
Well, I guess it would be best if you reverted those cleanups and resent. You can get my acked-by: on that; cc akpm. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |