lkml.org 
[lkml]   [2009]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: PATCH: README - Fix misleading pointer to the defconf directory
Date
On Friday 12 June 2009, Patrick Ringl wrote:
> the README simply points to a wrong/non-existent directory where the default
> configurations are not suited, hence the patch.

On six architectures, it's still the right directory, your patch breaks it.

> Signed-off-by: Patrick Ringl <patrick_@freenet.de>
>
> --- linux.orig/README 2009-06-10 05:05:27.000000000 +0200
> +++ linux/README 2009-06-12 10:46:15.000000000 +0200
> @@ -175,7 +175,7 @@
> Like above, but avoids cluttering the screen
> with questions already answered.
> "make defconfig" Create a ./.config file by using the default
> - symbol values from arch/$ARCH/defconfig.
> + symbol values from arch/$ARCH/configs/*_defconfig.
> "make allyesconfig"
> Create a ./.config file by setting symbol
> values to 'y' as much as possible.

You could write e.g.

default symbol values from one of arch/{$ARCH}/defconfig or
arch/${ARCH}/configs/${PLATFORM}_defconfig, depending on
the architecture.
It would also be consistent to list the specific defconfigs here, like

"make ${PLATFORM}_defconfig"
Create a ./.config file by using the default
symbol values from
arch/${ARCH}/configs/${PLATFORM}_defconfig.
Use "make help" to see a list of the available
platforms on your architecture.
Not also that your patch should be merged through a subsystem maintainer.
If you don't know who that is, use scripts/get_maintainer.pl.
For scripts/kconfig/* and README it suggests sending it to Sam, Roman and
linux-kbuild@vger.kernel.org, which sounds right.
Arnd <><


\
 
 \ /
  Last update: 2009-06-12 11:55    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site