lkml.org 
[lkml]   [2009]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: slab: setup allocators earlier in the boot sequence
    From
    Date
    On Fri, 2009-06-12 at 11:30 +0200, Nick Piggin wrote:
    > On Fri, Jun 12, 2009 at 07:24:20PM +1000, Benjamin Herrenschmidt wrote:
    > >
    > > > It's OK. I'd make it gfp_notsmellybits, and avoid the ~.
    > > > And read_mostly.
    > >
    > > read_mostly is fine. gfp_notsmellybits isn't a nice name :-) Make it
    > > gfp_allowedbits then. I did it backward on purpose though as the risk of
    > > "missing" bits here (as we may add new ones) is higher and it seemed to
    > > me generally simpler to just explicit spell out the ones to forbid
    > > (also, on powerpc, &~ is one instruction :-)
    >
    > But just do the ~ in the assignment. No missing bits :)

    Heh, ok.
    > Yeah but it doesn't do it in the page allocator so it isn't
    > really useful as a general allocator flags tweak. ATM it only
    > helps this case of slab allocator hackery.

    I though I did it in page_alloc.c too but I'm happy to be told what I
    missed :-) The intend is certainly do have a general allocator flag
    tweak.

    Cheers,
    Ben.




    \
     
     \ /
      Last update: 2009-06-12 11:47    [W:0.023 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site