Messages in this thread |  | | | From | KOSAKI Motohiro <> | | Subject | Re: [PATCH 2/3] check unevictable flag in lumy reclaim v2 | | Date | Thu, 11 Jun 2009 17:44:47 +0900 (JST) |
| |
> How about this ? > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Lumpy reclaim check pages from their pfn. Then, it can find unevictable pages > in its loop. > Abort lumpy reclaim when we find Unevictable page, we never get a lump > of pages for requested order. > > Changelog: v1->v2 > - rewrote commet.
Great. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > mm/vmscan.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > Index: lumpy-reclaim-trial/mm/vmscan.c > =================================================================== > --- lumpy-reclaim-trial.orig/mm/vmscan.c > +++ lumpy-reclaim-trial/mm/vmscan.c > @@ -936,6 +936,15 @@ static unsigned long isolate_lru_pages(u > /* Check that we have not crossed a zone boundary. */ > if (unlikely(page_zone_id(cursor_page) != zone_id)) > continue; > + /* > + * We tries to free all pages in this range to create > + * a free large page. Then, if the range includes a page > + * never be reclaimed, we have no reason to do more. > + * PageUnevictable page is not a page which can be > + * easily freed. Abort this scan now. > + */ > + if (unlikely(PageUnevictable(cursor_page))) > + break; > if (__isolate_lru_page(cursor_page, mode, file) == 0) { > list_move(&cursor_page->lru, dst); > nr_taken++; > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
|  |