Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/3] check unevictable flag in lumy reclaim | Date | Thu, 11 Jun 2009 17:24:58 +0900 (JST) |
| |
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Lumpy reclaim scans pages from their pfn. Then, it can find unevictable pages > in its loop. Abort lumpy reclaim when we find Unevictable page, we never get a > block of pages for requested order. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > Index: lumpy-reclaim-trial/mm/vmscan.c > =================================================================== > --- lumpy-reclaim-trial.orig/mm/vmscan.c > +++ lumpy-reclaim-trial/mm/vmscan.c > @@ -936,6 +936,9 @@ static unsigned long isolate_lru_pages(u > /* Check that we have not crossed a zone boundary. */ > if (unlikely(page_zone_id(cursor_page) != zone_id)) > continue; > + /* Abort when the page is mlocked */ > + if (unlikely(PageUnevictable(cursor_page))) > + break; > if (__isolate_lru_page(cursor_page, mode, file) == 0) { > list_move(&cursor_page->lru, dst); > nr_taken++; >
The code is good. thanks.
But please comment adding more. plus, unevictable is made by multiple reason. not only mlock. please fix misleading comment.
| |