Messages in this thread |  | | | Date | Thu, 11 Jun 2009 19:25:17 -0400 | | From | Dave Jones <> | | Subject | Re: [PATCH 3/6] cpumask: avoid playing with cpus_allowed in powernow-k8.c |
| |
On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote: > From: Rusty Russell <rusty@rustcorp.com.au> > > It's generally a very bad idea to mug some process's cpumask: it could > legitimately and reasonably be changed by root, which could break us > (if done before our code) or them (if we restore the wrong value). > > I did not replace powernowk8_target; it needs fixing, but it grabs a > mutex (so no smp_call_function_single here) but Mark points out it can > be called multiple times per second, so work_on_cpu is too heavy.
This one clashes with some diffs I merged earlier in cpufreq.git. Can you rebase on top of that please? (The other two were fine).
Otherwise, they all look ok to me. As long as they survive testing I see no reason not to push them for .31.
Thanks,
Dave
|  |