Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access | Date | Wed, 10 Jun 2009 23:13:00 -0500 |
| |
On May 12, 2009, at 3:35 AM, Li Yang wrote:
> Add the mapping functions used to support direct IO memory access of > rapidIO. > > Signed-off-by: Zhang Wei <zw@zh-kernel.org> > Signed-off-by: Li Yang <leoli@freescale.com>
Use inbnd/outbnd instead of inb/outb which make one think of byte level io accessors.
As I look at this I don't think this is the correct API. I think we should be using the DMA mapping API to hide these details. The concept of mapping like this seems to be more a function of FSL's Address translation/mapping unit (ATMU) than anything specific to the RIO bus standard.
> --- > drivers/rapidio/rio.c | 95 ++++++++++++++++++++++++++++++++++++++ > +++++++++ > include/linux/rio.h | 25 ++++++++++++ > include/linux/rio_drv.h | 24 +++++++++--- > 3 files changed, 138 insertions(+), 6 deletions(-)
- k
| |