Messages in this thread | | | Date | Thu, 11 Jun 2009 08:56:51 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] init: introduce mm_init() |
| |
On Thu, 11 Jun 2009, Pekka J Enberg wrote: > > +static void __init mm_init(void) > +{ > + /* > + * Set up kernel memory allocators > + */ > + mem_init(); > + kmem_cache_init(); > + vmalloc_init(); > +}
Please just put the comments at the top of the function in cases like this, ie just
/* * ... */ static int __init mm_init(void) { .. }
also, I'm now terminally confused about the whole series, so I'm wondering if you could re-do the series so that (a) I have a clear picture of what to take, and (b) preferably so it's also all bisectable (ie the trap_init ordering fixes are done in the initial mm/init.c changes).
Linus
| |