lkml.org 
[lkml]   [2009]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5 v3] x86: adapt CPU topology detection for AMD Magny-Cours
    On Sun, Jun 07, 2009 at 03:40:09PM +0200, Ingo Molnar wrote:
    >
    > * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
    >
    > > Changes to previous patch set:
    > > - remove MULTI_NODE_CPU config option
    > > - provide defaults for cpu_node topology information
    > > - add patch to fix AMD mcheck code
    > >
    > > Current patch set contains 5 patches:
    > > - patch 1 adapts common code to show cpu_node_id,
    > > cpu_node_siblings and cpu_node_siblings_list in
    > > /sys/devices/system/cpu/cpu*/topology
    > > - patch 2 prepares arch/x86 to provide cpu_node information
    > > - patch 3 sets up cpu_node information for AMD Magny-Cours CPU
    > > - patch 4 fixes L3 cache information for Magny-Cours
    > > - patch 5 fixes mcheck code for Magny-Cours
    >
    > it would be really nice to propagate this info to where it _really_
    > matters: the sched-domains topology info - unless i'm missing
    > something this patch-set does not do that yet, right?

    No scheduler modifcations contained in this patch set.

    > That way we'll get actual feedback if it's broken, and will help
    > people if it works right. Device allocation matters too, but to a
    > much lesser degree.

    With and w/o this patch set scheduler is broken for Magny-Cours.

    When performing

    # echo 2 >> /sys/devices/system/cpu/sched_mc_power_savings

    I get (both with and without above patches):

    CPU23 attaching sched-domain:
    domain 0: span 12-23 level MC
    groups: 23 12 13 14 15 16 17 18 19 20 21 22
    ERROR: parent span is not a superset of domain->span
    domain 1: span 18-23 level CPU
    ERROR: domain->groups does not contain CPU23
    groups: 12-17 (__cpu_power = 12288)
    ERROR: groups don't span domain->span
    domain 2: span 0-23 level NODE
    groups:
    ERROR: domain->cpu_power not set

    ERROR: groups don't span domain->span

    Output is from dmesg -- copied just the lines form the last CPU.

    I'd appreciate if you'd pull this patch set for .31. (Maybe I have
    to prepare an updated version to avoid conflicts.)

    I am working on the scheduler front. But don't know when
    first patches will be ready for review.


    Regards,
    Andreas

    --
    Operating | Advanced Micro Devices GmbH
    System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
    Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
    Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
    (OSRC) | Registergericht München, HRB Nr. 43632


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-11 17:43    [W:4.193 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site