Messages in this thread | | | Date | Thu, 11 Jun 2009 09:03:18 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 00/11] [GIT PULL] more updates for the tag format |
| |
On Wed, Jun 10, 2009 at 12:03:03PM -0400, Theodore Tso wrote: > Yes, another approach for handling this case would be to take my > "jbd2_dev_to_name" function and support it as a first-class tagged > type; after all, I'm sure ext4 won't be the only place that would like > to take a dev_t and print the device name. So this could certainly be > fixed by adding some kind of "<dev:xxx>" sort of tagged name.
We should absolutely agree on one way to represent block device for tracers. At this point xfs, gfs2 and the block tracer all use major/minor. I agree that having a name would be nicer for text output, but I really want to keep the dev_t for the binary output. We should also make sure we agree on a field name so that filtering will work the same for all block-related tracers (especially important if we want to trace something from the filesystem down to the block layer).
| |