lkml.org 
[lkml]   [2009]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mmc_spi: use EILSEQ for possible transmission errors
On Wed, Jun 10, 2009 at 09:29:49AM +0200, Wolfgang Mües wrote:
>
> From: Wolfgang Muees <wolfgang.mues@auerswald.de>
>
> o This patch changes the reported error code for the responses
>   to a command from EINVAL to EFAULT/ENOSYS, as EINVAL is reserved
>   for non-recoverable host errors, and the responses from
>   the SD/MMC card may be because of recoverable transmission
>   errors in the command or in the response. Response codes
>   in SPI mode are NOT protected by a checksum, so don't trust them.
>
> This is a revised, minimal-invasive patch version. As Pierre Ossman
> pointed out, EINVAL should only be used for non-recoverable errors
> (and is used so in the whole rest of the mmc framework).
>
> I have checked every instance of EINVAL in the mmc framework - no
> changes were needed here.
>
> This patch is neccessary for doing a sensible retry managment in the
> mmmc block layer (patch will follow).
>
> Signed-off-by: Wolfgang Muees <wolfgang.mues@auerswald.de>

Nice patch Wolfgang and well done for sticking this out ;-)

FWIW,
Acked-by: Matt Fleming <matt@console-pimps.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-06-10 09:41    [from the cache]
©2003-2011 Jasper Spaans