lkml.org 
[lkml]   [2009]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 11 Jun 2009 02:13:41 +0200
FromIngo Molnar <>
SubjectRe: [PATCH -tip] x86: perf_counter AMD supports performance monitoring for K7

* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/kernel/cpu/perf_counter.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
> index 240ca56..5d56742 100644
> --- a/arch/x86/kernel/cpu/perf_counter.c
> +++ b/arch/x86/kernel/cpu/perf_counter.c
> @@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
>
> static int amd_pmu_init(void)
> {
> + /* performance-monitoring supported from K7 */
> + if (boot_cpu_data.x86 < 7)
> + return -ENODEV;
> +
> x86_pmu = amd_pmu;
>
> switch (boot_cpu_data.x86) {

A commit under Linux consists of three parts:

1) the title
2) the changlog
3) the body

This sloppy patch of yours manages to get _all_ three wrong:

- the title is wrong (it is incorrect)
- the changelog is wrong (it is missing)
- the body is wrong (it is broken - K7 != family 7)

What the heck is going on here?

Ingo


\
 
 \ /
  Last update: 2009-06-11 02:17    [from the cache]
©2003-2010