lkml.org 
[lkml]   [2009]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][GIT PULL] tracing: do not translate event helper macros in print format

* Steven Rostedt <rostedt@goodmis.org> wrote:

> Ingo,
>
> This looks like it changed more than it really did, I only moved
> the one macro above another and added a few lines:
>
> +#undef __print_symbolic
> +#undef __get_dynamic_array
> +#undef __get_str
> +
>
> Please pull the latest tip/tracing/ftrace-1 tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/ftrace-1
>
>
> Steven Rostedt (1):
> tracing: do not translate event helper macros in print format
>
> ----
> include/trace/ftrace.h | 158 ++++++++++++++++++++++++-----------------------
> 1 files changed, 81 insertions(+), 77 deletions(-)
> ---------------------------
> commit 6ff9a64d2aaa6eae396adc95e9c91c0cbfa6dbe4
> Author: Steven Rostedt <srostedt@redhat.com>
> Date: Wed Jun 10 14:28:34 2009 -0400
>
> tracing: do not translate event helper macros in print format
>
> By moving the macro that creates the print format code above the
> defining of the event macro helpers (__get_str, __print_symbolic,
> and __get_dynamic_array), we get a little cleaner print format.
>
> Instead of:
>
> (char *)((void *)REC + REC->__data_loc_name)
>
> we get:
>
> __get_str(name)
>
> Instead of:
>
> ({ static const struct trace_print_flags symbols[] = { { HI_SOFTIRQ, "HI" }, {
>
> we get:
>
> __print_symbolic(REC->vec, { HI_SOFTIRQ, "HI" }, {

Yeah, that's really nice! Pulled, thanks Steve!

Ingo


\
 
 \ /
  Last update: 2009-06-10 22:51    [W:0.203 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site