Messages in this thread | | | Date | Mon, 01 Jun 2009 21:02:52 -0600 | From | Jordan Crouse <> | Subject | Re: [PATCH v2 001/001] gpio: AMD CS5535/CS5536 GPIO driver |
| |
Andres Salomon wrote: > On Mon, 1 Jun 2009 16:54:57 -0700 > Andrew Morton <akpm@linux-foundation.org> wrote: > [...] >> Back in February, Andres sent out a patch "cs553x-gpio: add AMD >> CS5535/CS5536 GPIO driver support". AFACIT that patch does the same >> thing that this one does, but differently. IIRC it had a great string >> of weird-Kconfig-related build errors and I eventually dropped it. >> >> What's the story here? >> >> Thanks. > > My story is that I've since switched employers twice since Feb, and will > be resubmitting the patch now that sanity has returned to my life. > I'm planning to get to it within the next week. > > As far as Tobias's driver, one major difference between our drivers is > that mine doesn't grab the entire PCI device. This is because other > drivers (ie, the MFGPT driver) will want to share the PCI device.
Also SMBUS. In fact, they *must* share the PCI device if they all want to play well together, so that alone would probably push us toward Andre's patch, once it gets clean.
Jordan
| |