Messages in this thread | | | Date | Mon, 01 Jun 2009 22:48:52 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH] KVM: add localversion to avoid confusion and conflicts |
| |
Steven Rostedt wrote: > >> This patch is only for KVM tree and not for linus tree. >> >> Lets assume 100 developers are working on kvm tree and they use kvm tree >> on 2 PCs. So count becomes 200. >> >> Like in my case I have dozen of kernel trees so I keep on swapping >> config between kernels. And I also need to test config from various >> users. So this count is countless. >> I think this is the biggest point for adding localversion in -tip. >> It seems Ingo is busy in perfcounter stuff otherwise he will explain you >> more advantages. >> >> In the least case, Can you differentiate between 1 and 200 ? >> >> So by adding this patch we can save lot of developer's time. >> > > No this patch wastes a lot of developers time. If we accept it, than any > patch that is added after it will need to be rebased before going to > Linus. Unless KVM is made up of a bunch of branches like tip is, this will become > more of a hassle than a benefit. >
kvm.git for-linus branches are rebased anyway, since I fold patches that fix or revert other patches. I also (rarely) delay some patches in my tree but submit others that came later.
localversion would show up in linux-next, not sure if that's a problem. On the other hand, I'm not sure what it's worth.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| |