lkml.org 
[lkml]   [2009]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [tip:perfcounters/core] perf_counter: Tidy up style details
    Date
    tip-bot for Ingo Molnar wrote:
    > @@ -3526,7 +3529,7 @@ inherit_counter(struct perf_counter *parent_counter,
    > /*
    > * Make the child state follow the state of the parent counter,
    > * not its hw_event.disabled bit. We hold the parent's mutex,
    > - * so we won't race with perf_counter_{en,dis}able_family.
    > + * so we won't race with perf_counter_{en, dis}able_family.
    > */
    > if (parent_counter->state >= PERF_COUNTER_STATE_INACTIVE)
    > child_counter->state = PERF_COUNTER_STATE_INACTIVE;

    I wouldn't call this an improvement TBH.

    perf_counter_{en,dis}able_family expands to
    perf_counter_enable_family + perf_counter_disable_family

    while perf_counter_{en, dis}able_family expands to
    perf_counter_enable_family + "perf_counter_ disable_family"

    Cheers,
    FJP


    \
     
     \ /
      Last update: 2009-06-01 20:25    [W:0.045 / U:29.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site